Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZCash] Fetch consensus branch id from the backend - 1.74.x #27092

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Dec 24, 2024

Uplift for #27089
Fixes brave/brave-browser#42951

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

cypt4 and others added 2 commits December 24, 2024 18:47
@kjozwiak kjozwiak added this to the 1.74.x - Beta milestone Dec 28, 2024
@kjozwiak kjozwiak changed the title Brave uplift 27089 1.74.x [ZCash] Fetch consensus branch id from the backend - 1.74.x Dec 28, 2024
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.74.x approved 👍 QA has verified the PR on Nightly using 1.75.x as per #27089 (comment).

@kjozwiak kjozwiak merged commit 2810f96 into 1.74.x Jan 6, 2025
16 checks passed
@kjozwiak kjozwiak deleted the brave_uplift_27089_1.74.x branch January 6, 2025 08:38
@brave-builds
Copy link
Collaborator

Released in v1.74.44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants